Add the max_uint subcommand to cast and cli #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hammeiam
commented
Dec 13, 2021
•
hammeiam
commented
mattsse
approved these changes
Dec 13, 2021
cli/src/cast_opts.rs
Outdated
| @@ -12,6 +12,9 @@ use structopt::StructOpt; | |||
| #[derive(Debug, StructOpt)] | |||
| #[structopt(about = "Perform Ethereum RPC calls from the comfort of your command line.")] | |||
| pub enum Subcommands { | |||
| #[structopt(name = "--max-uint")] | |||
| #[structopt(about = "maximum u256 value")] | |||
| MaxUint { }, | |||
There was a problem hiding this comment.
Suggested change
| MaxUint { }, | |
| MaxUint, |
this should still work I suppose?
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
shekhirin
reviewed
Dec 13, 2021
| /// assert_eq!(U256::MAX, Cast::max_uint()?); | ||
| /// | ||
| /// Ok(()) | ||
| /// } |
There was a problem hiding this comment.
Suggested change
| /// } | |
| /// } | |
| /// ``` |
hammeiam
commented
Dec 13, 2021
cli/src/forge.rs
Outdated
| @@ -1,4 +1,7 @@ | |||
| use ethers::solc::{remappings::Remapping, Project, ProjectPathsConfig}; | |||
| use ethers::{ | |||
| prelude::{ArtifactOutput, ContractFactory, MinimalCombinedArtifacts, Provider}, | |||
There was a problem hiding this comment.
Since these imports are unused, they seem to cause clippy to return a warning
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.