Skip to content

feat: add code to cast #242

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Dec 17, 2021
Merged

feat: add code to cast #242

merged 3 commits into from
Dec 17, 2021

Conversation

rajivpo
Copy link
Contributor

@rajivpo rajivpo commented Dec 17, 2021

Tested by running both seth code 0x00000000219ab540356cbb839cbe05303d7705fa and cargo run --bin cast code --rpc-url $RPC_URL 0x00000000219ab540356cbb839cbe05303d7705fa and validated that the outputs were equal via diffchecker.

Feedback regarding implementation is welcome as I'm a Rust n00b and if there is more to be desired around test coverage, happy to update accordingly.

@gakonst
Copy link
Member

gakonst commented Dec 17, 2021

Looking good! I rebased to resolve a merge conflict, fixed some new lint errors which came up due to newer clippy versions, and also added a doc test. Thanks for the contribution, we wish to see you again :) Make sure to join the chatroom

@gakonst gakonst merged commit a939c12 into foundry-rs:master Dec 17, 2021
@gakonst gakonst mentioned this pull request Dec 21, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants