Skip to content

refactor: use TestFunctionExt for string #2586

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 3, 2022
Merged

refactor: use TestFunctionExt for string #2586

merged 2 commits into from
Aug 3, 2022

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Aug 3, 2022

Motivation

use TestFunctionExt for string to easily check if a str is a test/failure/setup

Solution

  • move traits to common
  • use on strings

@mattsse mattsse added L-ignore Log: ignore PR in changelog T-debt Type: code debt labels Aug 3, 2022
onbjerg
onbjerg approved these changes Aug 3, 2022
View reviewed changes
Copy link
Collaborator

@onbjerg onbjerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, smol comments

@mattsse mattsse merged commit 438b758 into foundry-rs:master Aug 3, 2022
@gakonst
Copy link
Member

gakonst commented Aug 3, 2022

@mattsse do we want this for invariants as well? #1572

@mattsse
Copy link
Member Author

mattsse commented Aug 3, 2022 •
edited
Loading

definitely, @joshieDo could you please go over #1572 and extend the trait with naming convention for invariants?
could also do in a followup and get #1572 merged first

iFrostizz pushed a commit to iFrostizz/foundry that referenced this pull request Nov 9, 2022
@mattsse @iFrostizz
refactor: use TestFunctionExt for string (foundry-rs#2586)
3250a7d 
* refactor: use TestFunctionExt for string

* add unimplemented
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@onbjerg onbjerg onbjerg approved these changes

Assignees
No one assigned
Labels
L-ignore Log: ignore PR in changelog T-debt Type: code debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattsse @gakonst @onbjerg