fix(forge): record snapshot failures correctly #3087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
mattsse
force-pushed
the
matt/record-snapshot-failures-correctly
branch
from
e87e56d to
4f3e4c2
Compare
mattsse
force-pushed
the
matt/record-snapshot-failures-correctly
branch
from
4f3e4c2 to
709ff80
Compare
gakonst
approved these changes
Sep 5, 2022
|
lgtm pending conflict fix |
onbjerg
force-pushed
the
matt/record-snapshot-failures-correctly
branch
from
709ff80 to
923a8f4
Compare
|
rebased, waiting for ci |
mattsse
force-pushed
the
matt/record-snapshot-failures-correctly
branch
from
923a8f4 to
b7edd1c
Compare
iFrostizz
pushed a commit
to iFrostizz/foundry
that referenced
this pull request
Nov 9, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #3055
there were some changes in revm state recording, so we need to check the
JournaledState's present value of the slot that contains thefailedvariable when we revert a snapshot to record if there was a failure in a reverted snapshotSolution