feat(forge): error hints #3135
feat(forge): error hints #3135
Conversation
onbjerg
force-pushed
the
onbjerg/error-hints
branch
from
643b25a to
6269656
Compare
|
@gakonst adding an example rn, but for example u could use it for |
|
Not the best example (expectEmit will take more work) but instead of writing the really big number inside of the short test result it could be a hint:
Similarly, sometimes the forking backend might fail for whatever reason - it might be that the account is not accessible on your node, so a hint could be added that it's too far back if we think it is and suggest an archive node or moving the block you're forking from |
|
OK! This makes sense. Supportive. |
| Ok(match code { | ||
| 0x00 => SolidityPanic::Generic, | ||
| 0x01 => SolidityPanic::Assert, | ||
| 0x11 => SolidityPanic::OverUnderFlow, | ||
| 0x12 => SolidityPanic::DivideByZero, | ||
| 0x21 => SolidityPanic::InvalidEnumCast, | ||
| 0x22 => SolidityPanic::InvalidStorageByteArray, | ||
| 0x31 => SolidityPanic::PopOnEmptyArray, | ||
| 0x32 => SolidityPanic::IndexOutOfBounds, | ||
| 0x41 => SolidityPanic::Alloc, | ||
| 0x51 => SolidityPanic::InvalidPointer, | ||
| code => SolidityPanic::Unknown(code), |
There was a problem hiding this comment.
could move this to a separate From impl
|
Closing as stale. |
Motivation
Some cheatcodes lack context when they fail, but our current setup does not allow us to add very much context without the output of
forge testbecoming super clutteredSolution
Allow reverts from our backend and our inspectors to include optional hints
Effectively closes #928 as some of the more annoying cheatcode reverts are documented in other issues