Skip to content

fix: panic hook panic #3182

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 13, 2022
Merged

fix: panic hook panic #3182

merged 1 commit into from
Sep 13, 2022

Conversation

mattsse
Copy link
Member

@mattsse mattsse commented Sep 12, 2022

Motivation

Closes #3050

this could be related to this windows+lto issue rust-lang/rust#81408 with once_cell (the eyre HOOK is a once_cell)

because there's nothing else that sets the hook, so it would only fail if once_cell itself fails to set it...

Solution

  • makes installing the panic hook a noop on windows

@mattsse mattsse added the T-bug Type: bug label Sep 12, 2022
@gakonst gakonst merged commit 776c14c into foundry-rs:master Sep 13, 2022
iFrostizz pushed a commit to iFrostizz/foundry that referenced this pull request Nov 9, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
T-bug Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fresh windows 10 install - ErrorHook issue
2 participants