feat(evm): make vm.snapshots persistent
#5487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evalir
commented
Jul 27, 2023
Comment on lines
+117
to
+119
| let snapshot = { self.snapshots().lock().remove_at(id) }; | ||
| if let Some(snapshot) = snapshot { | ||
| self.snapshots().lock().insert_at(snapshot.clone(), id); |
There was a problem hiding this comment.
Kind of looks like a deadlock from a glance but it's not haha—both guards are dropped on the spot
mattsse
approved these changes
Jul 28, 2023
2 tasks
maa105
added a commit
to maa105/foundry
that referenced
this pull request
Nov 23, 2023
This reverts commit 41bae8e.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #5118
Right now snapshots are not persisted, and snapshots created after the snapshot to be deleted are also deleted.
Solution
Remove this legacy behavior by just persisting snapshots.
We now have a few more clones as a result of this, but it should be OK—this is an infrequent operation.