fix(invariant): exclude default addresses from senders #8118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Jun 8, 2024
Comment on lines
500
to
504
| excluded_senders.extend(vec![ | ||
| CHEATCODE_ADDRESS, | ||
| HARDHAT_CONSOLE_ADDRESS, | ||
| DEFAULT_CREATE2_DEPLOYER, | ||
| ]); |
There was a problem hiding this comment.
I think we can use an array here
DaniPopes
reviewed
Jun 8, 2024
| excluded_senders.extend([ | ||
| CHEATCODE_ADDRESS, | ||
| HARDHAT_CONSOLE_ADDRESS, | ||
| DEFAULT_CREATE2_DEPLOYER, |
There was a problem hiding this comment.
We should consider having a const for these addresses since we reference them individually in a lot of places
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #4163
Solution
CHEATCODE_ADDRESS,HARDHAT_CONSOLE_ADDRESSandDEFAULT_CREATE2_DEPLOYERfrom senders