-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: some verify-bytecode fixes #8513
Conversation
Thanks I'm a fan of this approach. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@klkvr There was a breaking change in this PR. The
|
* fix: some verify-bytecode fixes * update constructor args handling * --encoded-constructor-args * warn on length mismatch --------- Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Cleans up code a bit, removing redundant
Result
and preferring checkingmatch_type.is_none()
instead of keeping a separate bool.Also removes
--verification-type
flag as it doesn't make much sense because user'd expect us to determine match type during comparison.Closes #8505. The cause is etherscan bug - it returns invalid constructor arguments for mentioned contract.
I've updated logic to not rely on etherscan constructor args if
--constructor-args
are passed.Also updated
--constructor-args
to expect multiple values and abi-encode them similarly toforge create
as this seems to be the expected UX at least by the author of #8505. I've kept an option for abi-encoded args as--encoded-constructor-args