Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(anvil): apply Arbitrum specifics to API block #8542

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

grandizzy
Copy link
Collaborator

Motivation

Closes #8537

in #7360 Arbitrum block number returned by eth_blockNumber was fixed but chain specifics weren't applied to other calls ( like eth_getBlockByNumber)

Solution

  • used best block for block number and apply chain specifics when converting block to eth api conform format

@grandizzy grandizzy marked this pull request as ready for review July 27, 2024 12:37
Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pending @mattsse

@mattsse mattsse merged commit dc23de3 into foundry-rs:master Jul 29, 2024
20 checks passed
benwjhack pushed a commit to CompassLabs/foundry-test that referenced this pull request Sep 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(anvil): inconsistencies in Arbitrum forked anvil instance
3 participants