fix(verify-bytecode): extract constructor arguments from creation code
#8547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
changed the title
verify-bytecode): extract constructor arguments from creation code
mattsse
approved these changes
Jul 29, 2024
zerosnacks
added a commit
that referenced
this pull request
Jul 29, 2024
2 tasks
benwjhack
pushed a commit
to CompassLabs/foundry-test
that referenced
this pull request
Sep 11, 2024
…ode (foundry-rs#8547) fix verify-bytecode: extract constructor arguments from creation code
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #8545
Solution
If Etherescan returned incorrect constructor arguments, replace them with latest bytes of on-chain creation code, based on the length of local creation code. This should work well as long as metadata settings are same for both local and on-chain contracts (either both contain metadata, or both don't contain).