Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(fmt): surround with returns in fn with format disabled #8582

Merged
merged 1 commit into from
Aug 1, 2024
Merged

fix(fmt): surround with returns in fn with format disabled #8582

merged 1 commit into from
Aug 1, 2024

Conversation

grandizzy
Copy link
Collaborator

Motivation

Closes #7920

Solution

  • if fn with returns format is disabled, surround returned params in returns () to produce valid Solidity

@grandizzy grandizzy marked this pull request as ready for review August 1, 2024 13:06
@grandizzy grandizzy enabled auto-merge (squash) August 1, 2024 13:48
mattsse
mattsse approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@grandizzy grandizzy merged commit 0951fb5 into foundry-rs:master Aug 1, 2024
20 checks passed
benwjhack pushed a commit to CompassLabs/foundry-test that referenced this pull request Sep 11, 2024
@grandizzy @benwjhack
fix(fmt): surround with returns in fn with format disabled (foundry-r…
d926f90 
…s#8582)

fix(fmt): surround returns if fn format disabled
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: forge fmt can't handle // forgefmt: disable-next-line with an inline comment on the next line
2 participants
@grandizzy @mattsse