feat(cheatcodes): display warnings for deprecated cheatcodes #8883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grandizzy
changed the title
grandizzy
requested review from
DaniPopes,
klkvr and
mattsse
as code owners
zerosnacks
reviewed
Sep 17, 2024
zerosnacks
reviewed
Sep 17, 2024
|
I would rather implement this as a hashset stored in cheatcodes struct and then reported after, it also should report the other statuses; this spams the logs as it's logged on each call |
DaniPopes
changed the title
grandizzy
changed the title
@DaniPopes before adding support for fuzz and invariant kinds, can you ptal and lmk if that's inline with what you're thinking at 43fd48c showing single warning per test suite as in |
grandizzy
force-pushed
the
deprecate-cheatcodes
branch
from
597a2e3
to
62838fe
Compare
grandizzy
force-pushed
the
deprecate-cheatcodes
branch
from
0d5f663
to
291692a
Compare
grandizzy
changed the title
DaniPopes
reviewed
Sep 19, 2024
grandizzy
changed the title
grandizzy
changed the title
DaniPopes
reviewed
Sep 20, 2024
DaniPopes
reviewed
Sep 20, 2024
DaniPopes
reviewed
Sep 20, 2024
Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
DaniPopes
approved these changes
Sep 20, 2024
rplusq
pushed a commit
to rplusq/foundry
that referenced
this pull request
Sep 25, 2024
…-rs#8883) * feat(cheatcode): disaply message for cheatcodes marked as deprecated * Deprecated cheatcodes as hashset, displayed once per test suite * Add deprecated cheatcode replacement attr * Add support for fuzz and invariant tests * Changes after review: add Deprecated(replacement) * Update crates/cheatcodes/src/inspector.rs Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com> * chore: touchups * Fix CI --------- Co-authored-by: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
2 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#[cheatcode(group = Json, status = Deprecated("keyExistsJson")]Solution