Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: implement parseTomlType cheats #8911

Merged
merged 5 commits into from
Sep 20, 2024

Conversation

leovct
Copy link
Contributor

@leovct leovct commented Sep 19, 2024

Motivation

Closes #8810

Solution

Mostly a copy/paste of #8345.

Minor: removal of references of json in testdata/default/cheats/Toml.t.sol and use of toml instead.

@leovct leovct marked this pull request as ready for review September 19, 2024 23:58
Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is great!

Minor feedback in regards to naming change in test

testdata/default/cheats/Toml.t.sol Outdated Show resolved Hide resolved
@zerosnacks zerosnacks self-requested a review September 20, 2024 09:51
@DaniPopes
Copy link
Member

PTAL @klkvr

@klkvr klkvr merged commit f2c14c1 into foundry-rs:master Sep 20, 2024
20 checks passed
@leovct leovct deleted the feat/parse-toml-type-cheats branch September 20, 2024 15:01
rplusq pushed a commit to rplusq/foundry that referenced this pull request Sep 25, 2024
* feat: implement `parseTomlType` cheats

* chore: `forge fmt`

* revert: use json naming to indicate to users that they are operating on json data

* chore: nit

* chore: nit
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(cheatcodes): add vm.parseTomlType
4 participants