Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore(anvil): use dyn DatabaseRef instead of generics #8920

Merged
merged 3 commits into from
Sep 21, 2024
Merged

chore(anvil): use dyn DatabaseRef instead of generics #8920

merged 3 commits into from
Sep 21, 2024

Conversation

DaniPopes
Copy link
Member

Trait aliases and upcasting make this way nicer, it is what it is

mattsse
mattsse approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is what it is

@DaniPopes DaniPopes enabled auto-merge (squash) September 21, 2024 14:48
@DaniPopes DaniPopes merged commit ed3ed15 into master Sep 21, 2024
21 checks passed
@DaniPopes DaniPopes deleted the dani/anvil-dyn-dbref branch September 21, 2024 15:17
rplusq pushed a commit to rplusq/foundry that referenced this pull request Sep 25, 2024
@DaniPopes @rplusq
chore(anvil): use dyn DatabaseRef instead of generics (foundry-rs#8920)
184b04b
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @mattsse