Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: fixes for --all-features tests #8937

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

grandizzy
Copy link
Collaborator

@grandizzy grandizzy commented Sep 23, 2024

Motivation

more fixes in the effort to make cargo test --all --all-features run clean

  • cast receipt_revert_reason: use next http endpoint for 2nd call to avoid rate limits
  • cast send_requires_to and mktx_requires_to: panicd error sending request for url (http://localhost:8545/), pass --chain=1 to avoid such
  • inline_config_run_fuzz: make sure fresh runner so there's no failed fuzz persisted / needed to rerun

TBD: there's still occasionally failing tests (seen in cast and soldeer) e.g.

thread 'storage' panicked at crates/cast/tests/cli/main.rs:1021:10:
Expected success, was 101

Solution

Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rpc rate limiting 👍

@grandizzy grandizzy marked this pull request as ready for review September 23, 2024 17:29
@grandizzy grandizzy merged commit 07a1f67 into foundry-rs:master Sep 23, 2024
20 checks passed
@grandizzy grandizzy deleted the chore-test-all branch September 23, 2024 17:29
rplusq pushed a commit to rplusq/foundry that referenced this pull request Sep 25, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants