New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

chore: reduce size of DynCheatcode vtable #9023

Merged

mattsse merged 1 commit into master from dani/dyn-cheatcode-vtable-size

Oct 3, 2024

Member

DaniPopes commented Oct 3, 2024

Move default trait methods from the trait to impl dyn DynCheatcode to reduce the size of the vtable.


          chore: reduce size of DynCheatcode vtable

fd0afac

DaniPopes requested review from klkvr, mattsse, grandizzy, yash-atreya and zerosnacks as code owners

October 3, 2024 17:37

mattsse approved these changes

View reviewed changes

mattsse merged commit e10ab3d into master

21 checks passed

mattsse deleted the dani/dyn-cheatcode-vtable-size branch

October 3, 2024 18:04

# for free to join this conversation on GitHub. Already have an account? # to comment

Reviewers

mattsse mattsse approved these changes

klkvr Awaiting requested review from klkvr klkvr is a code owner

grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Labels

None yet