Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add support for basic vyper project using forge init --vyper #9930

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

startup-dreamer
Copy link
Contributor

@startup-dreamer startup-dreamer commented Feb 21, 2025

Closes: #8340

This PR aims to add forge init --vyper command which instantiate a basic vyper project like this project as suggested here #8340 (comment).

This command mimics forge init --template https://github.com/Patronum-Labs/foundry-vyper currently the standard way of initializing a vyper project.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link
Member

@zerosnacks zerosnacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @startup-dreamer, thanks for your PR

I would prefer if the Vyper template used local files, see: https://github.com/foundry-rs/foundry/tree/master/crates/forge/assets

We will have to move the Solidity ones in their respective subfolder in the assets directory and create a Vyper equivalent

Thanks!

@startup-dreamer
Copy link
Contributor Author

Makes sense, I'll do the changes.

@startup-dreamer startup-dreamer marked this pull request as draft February 25, 2025 08:28
@zerosnacks
Copy link
Member

Hey @startup-dreamer, if time permits - would be great to get this in! Thanks

@startup-dreamer
Copy link
Contributor Author

Hey @startup-dreamer, if time permits - would be great to get this in! Thanks

I will try to ship this by the end of weekend.

@startup-dreamer startup-dreamer force-pushed the feat/add_forge_vyper_init_flag branch from 5528dc5 to 985132e Compare March 29, 2025 20:07
@startup-dreamer

This comment was marked as outdated.

@startup-dreamer startup-dreamer force-pushed the feat/add_forge_vyper_init_flag branch from 985132e to ec2d2f1 Compare March 30, 2025 15:15
@startup-dreamer startup-dreamer force-pushed the feat/add_forge_vyper_init_flag branch from ec2d2f1 to 5b06b8e Compare March 30, 2025 16:05
@startup-dreamer startup-dreamer marked this pull request as ready for review March 30, 2025 16:18
@zerosnacks
Copy link
Member

Thanks! This is looking great

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

feat(forge init): add --vyper flag to initialize a basic Vyper project mirroring Counter
2 participants