-
Notifications
You must be signed in to change notification settings - Fork 1
Self host types to enable experimentation #3
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
@fox1t Regarding your feedback on modules-playground/self-hosted-namespace/typescript/es-module-interop-false/index.ts Lines 1 to 5 in b8415d7
It forces people that want to use a legacy TS esm approach to rather than importing it as a esm module import it as a cjs module, that sounds ok to me? On top of that, modules-playground/self-hosted-namespace/typescript/es-module-interop-true/index.ts Lines 1 to 5 in b8415d7
|
@voxpelli I agree with you. The problem is the reality of the TS developers today: many doesn't even know anything about import helloWorldRequire = require("../../") and the ones that know don't want to use it. We were at the point of having more TS and ESM import/export related issues than "real" code issues opened across all of the Fasitfy core repositories. When we decided to make the change and use the "infamous triplet" they just dropped: yours is the first one since months :/ We decided to not force TS users to use |
@voxpelli can you resolve conflict so we can merge this PR and iterate over it? I want to change the "selft hosted triplet" to 3 different kind of pacakges:
This will allow us to test all export scenarios in all import scenarios. :) |
Fixed the conflicts @fox1t, not sure I get what scenarios you want to be added So right now there are two self-hosted examples:
Each with five test cases:
Where would you want to add something or change something? |
Nice! After merging this PR this is the general idea. IntroductionWhen I say "package with the triplet" I mean a package that exports:
When I say "package without the triplet" I mean a package that exports:
This is the check list on the additions:
|
@fox1t Right, something you want to do or should I try to find some time to give it a shot? |
I am adding point 1 right now. I am going to open a PR and add you as reviewer ok? |
@fox1t Totally ok! |
This PR is built on top of #2 and adds self-hosted minimal implementations of the relevant types, to enable experimentation with solutions and thus to work towards a solution