Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Get rid of require_matching_ehlo #280

Closed
3 tasks done
foxcpp opened this issue Oct 10, 2020 · 0 comments
Closed
3 tasks done

Get rid of require_matching_ehlo #280

foxcpp opened this issue Oct 10, 2020 · 0 comments
Assignees
@foxcpp
Labels
mta-in Related to incoming message processing part of the MTA functionality (mail exchanger). ready-for-release Feature is implemented and available for testing in dev branch. It will be included in the next rele
Milestone
0.6

Comments

@foxcpp
Copy link
Owner

foxcpp commented Oct 10, 2020 •
edited
Loading

This is the remnant of dark ages when maddy had no SPF support. The check is overly strict and seems to produce false positives for several big ESPs (including Gmail and Outlook).

Plan:

  • Disable by default in 0.4.1
  • Deprecate in in 0.5
  • Completely remove in 0.6
@foxcpp foxcpp added the mta-in Related to incoming message processing part of the MTA functionality (mail exchanger). label Oct 10, 2020
@foxcpp foxcpp added this to the 0.5 milestone Oct 10, 2020
@foxcpp foxcpp added the good first issue Easy to do, good for newcomers. label Oct 10, 2020
foxcpp added a commit that referenced this issue Oct 11, 2020
@foxcpp
Update default config
5e9d910 
Move checks to "smtp". Closes #274.
Do not use require_matching_ehlo. See #280.
@foxcpp foxcpp removed the good first issue Easy to do, good for newcomers. label Oct 12, 2020
foxcpp added a commit that referenced this issue Jul 9, 2021
@foxcpp
check/dns: Mark require_matching_echo as deprecated
c55bf8e 
See #280.
@foxcpp foxcpp modified the milestones: 0.5, 0.6 Aug 9, 2021
@foxcpp foxcpp self-assigned this Jun 18, 2022
@foxcpp foxcpp added the ready-for-release Feature is implemented and available for testing in dev branch. It will be included in the next rele label Jun 18, 2022
foxcpp added a commit that referenced this issue Jun 23, 2022
@foxcpp
check: Remove require_matching_echo
9dd34b8 
See #280.
@foxcpp foxcpp closed this as completed Jun 23, 2022
shift pushed a commit to shift/maddy that referenced this issue Jul 5, 2022
@foxcpp @shift
check: Remove require_matching_echo
7a927c9 
See foxcpp#280.
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@foxcpp foxcpp

Labels
mta-in Related to incoming message processing part of the MTA functionality (mail exchanger). ready-for-release Feature is implemented and available for testing in dev branch. It will be included in the next rele
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
1 participant
@foxcpp