feat: Session management #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elementbound
commented
Dec 4, 2024
elementbound
force-pushed
the
feat/base-dao
branch
from
9e71ab0 to
074f293
Compare
elementbound
force-pushed
the
feat/session-management
branch
from
992a4f2 to
303f587
Compare
ocsi0520
requested changes
Dec 7, 2024
packages/server/src/assert.ts
Outdated
| @@ -0,0 +1,5 @@ | |||
| export function assert(condition: boolean, message: string = ''): void { | |||
There was a problem hiding this comment.
server-side we can use node:assert
https://bun.sh/docs/runtime/nodejs-apis
packages/server/tsconfig.build.json
Outdated
| @@ -1,4 +1,4 @@ | |||
| { | |||
There was a problem hiding this comment.
I got that, that we have a separate tsconfig only for build, where we can exclude the type-checks on
node_modules, test, dist, and test files, but where do we reference it?
There was a problem hiding this comment.
IIIRC it's a leftover from nest's starter template. Removed, since we don't actually transpile server code.
elementbound
force-pushed
the
feat/session-management
branch
from
b418c2a to
11534c6
Compare
ocsi0520
approved these changes
Dec 12, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23