fix: support tag.div and tag(Component) #302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: support tag.div`` and tag(Component)``
Description
The tagged template support from #41 only supported the very basic
tag`...`
format, but not formats such astag.div`...`
ortag(Component)`...`
. This reads the object and callee of the tag to process those as well.Libraries such as twc and twin.micro use this pattern.
Fixes #272
Node Support
I used Optional Chaining and the Nullish coalescing operator - these are only supported in Node 14.0.0 and higher, so I bumped the
engines
field.Node 12 is EoL for over 2 years, but I can update it to alternative syntax if you like.
Type of change
How Has This Been Tested?
Test cases added. I also added missing template tag tests for all the rules.
Test Configuration:
Checklist:
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationNote that this does not change anything, but tagged template documentation was already missing and is available here: Update README.md #288Any dependent changes have been merged and published in downstream modules