-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix ast expression tests for null expressions #345
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a TypeError exception for null expressions. TypeError: Cannot read properties of null (reading 'type') Occurred while linting /app/src/components/TestComponent.vue:47 Rule: "vue/attributes-order" at isArrayExpression (/app/node_modules/eslint-plugin-tailwindcss/lib/util/ast.js:99:92) at isVueValidAttributeValue (/app/node_modules/eslint-plugin-tailwindcss/lib/util/ast.js:121:10) at Object.isValidVueAttribute (/app/node_modules/eslint-plugin-tailwindcss/lib/util/ast.js:184:8)
@kesor could you provide an example of the failing AST parsing ? Thank you |
This is a bit hard to debug, but if I am not mistaken it would be this Vue.js element --
Some debug logging that I patched the
|
Thanks, I was able to reproduce the BUG then to confirm the fix is working as expected. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Name
Fix a TypeError exception for null expressions in the AST.
Description
While linting my application, exceptions about the AST are raised in some components:
Apparently the
VExpressionContainer
can pass all the checks, but the value forexpression
isnull
. This modification makes sure it is not treated as an object that can be passed onward.Type of change
How Has This Been Tested?
Linting fails on some components in our big application, this change fixes the thrown exception.
Test Configuration: