Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: right-aligned numbers in tables #363

Merged

Conversation

UmakanthKaspa
Copy link
Contributor

This PR enhances the table component by:

  • Bolding and center-aligning the table headers.
  • Right-aligning numeric columns.
  • Adding hover effects on rows for better user interactivity.

Closes #311 — This PR addresses the feature request for bolding and centering table headings as described in the issue #311

Before:
image

After:

image

@nextchamp-saqib
Copy link
Member

Bolding and center-aligning the table headers.

I think the headers are secondary and it just serves as reference. Making them bold will make them stand out more than actual data. I think it's better to keep them as they are.

Adding hover effects on rows for better user interactivity.

Hover effects are used to indicate that the row is interactive. But there is no interaction like clicking or selecting a row. So I think it is not necessary. I'll add clicking & copying interaction in future.

Will just keep the right-aligned header change and merge

@nextchamp-saqib nextchamp-saqib changed the title Enhance table headers: bold, center-aligned, and right-aligned numbers fix: right-aligned numbers in tables Dec 10, 2024
@nextchamp-saqib nextchamp-saqib merged commit b2070b2 into frappe:develop Dec 10, 2024
@UmakanthKaspa
Copy link
Contributor Author

Bolding and center-aligning the table headers.

I think the headers are secondary and it just serves as reference. Making them bold will make them stand out more than actual data. I think it's better to keep them as they are.

Adding hover effects on rows for better user interactivity.

Hover effects are used to indicate that the row is interactive. But there is no interaction like clicking or selecting a row. So I think it is not necessary. I'll add clicking & copying interaction in future.

Will just keep the right-aligned header change and merge

Thanks for the feedback! 🙌

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table Heading
2 participants