Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Implement linting workflow #4

Closed
fhg-isi opened this issue Dec 23, 2024 · 0 comments
Closed

Implement linting workflow #4

fhg-isi opened this issue Dec 23, 2024 · 0 comments
Assignees
@fhg-isi

Comments

@fhg-isi
Copy link
Contributor

fhg-isi commented Dec 23, 2024 •
edited
Loading

Implement a linting workflow that does not require pylint because pylint has GPL2 license.

Also see

pylint-dev/pylint#10145

ruff supports less rules than pylint:

astral-sh/ruff#970

ruff and flake8 do not seem to provide a score feature like pylint... which would be nice to show the score as a badge.

https://stackoverflow.com/questions/79303531/how-to-get-linting-score-from-ruff-similar-to-pylint-score
@fhg-isi fhg-isi self-assigned this Dec 23, 2024
fhg-isi added a commit that referenced this issue Jan 9, 2025
@fhg-isi
started to include ruff #4
c29a465
fhg-isi added a commit that referenced this issue Jan 9, 2025
@fhg-isi
continued with ruff linting #4
453a638
fhg-isi added a commit that referenced this issue Jan 9, 2025
@fhg-isi
continued to apply ruff #4
84b7eee
fhg-isi added a commit that referenced this issue Jan 9, 2025
@fhg-isi
continued to apply ruff #4
292f35f
fhg-isi pushed a commit that referenced this issue Jan 9, 2025
fixed version numbers and resolved some warnings #9, #4
7ab7bd9
fhg-isi pushed a commit that referenced this issue Jan 9, 2025
continued with ruff warnings #4
c55fe75
fhg-isi pushed a commit that referenced this issue Jan 9, 2025
continued to resolve warnings #4
0f9b59c
fhg-isi added a commit that referenced this issue Jan 9, 2025
@fhg-isi
continued to fix ruff warnings #4
9ecb1f0
fhg-isi added a commit that referenced this issue Jan 9, 2025
@fhg-isi
continued to fix ruff warnings #4
6cfb208
fhg-isi added a commit that referenced this issue Jan 9, 2025
@fhg-isi
continued to fix ruff warnings #4
7ac06b5
fhg-isi pushed a commit that referenced this issue Jan 10, 2025
included extra workflow for name checks #4
d51b9f5 
reduced some warnings
fhg-isi pushed a commit that referenced this issue Jan 10, 2025
removed unused function #4
cf3a723
fhg-isi pushed a commit that referenced this issue Jan 10, 2025
fixed distance calculation
e0105a2 
reduced ruff warnings #4
fhg-isi pushed a commit that referenced this issue Jan 10, 2025
fixed some pylint warnings #4
9dcff79
fhg-isi pushed a commit that referenced this issue Jan 10, 2025
formatted files with black #4
9272d5b
fhg-isi pushed a commit that referenced this issue Jan 10, 2025
applied ruff to format text
771eb0b 
removed black as a dependency
included ruff format in lint workflow
#4
fhg-isi pushed a commit that referenced this issue Jan 10, 2025
enabled fix option for ruff and github output format #4
e2024e9
fhg-isi pushed a commit that referenced this issue Jan 10, 2025
applied ruff format #4
321fecb
fhg-isi pushed a commit that referenced this issue Jan 10, 2025
trying to simplify license check #4
d79bbfe
@fhg-isi fhg-isi closed this as completed Jan 10, 2025
fhg-isi added a commit that referenced this issue Jan 10, 2025
@fhg-isi
fixed some intents #4
e192580
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@fhg-isi fhg-isi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fhg-isi