Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix Countdown #623

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Fix Countdown #623

wants to merge 7 commits into from

Conversation

1ceit
Copy link
Member

@1ceit 1ceit commented Dec 20, 2024

  • Fix countdown by adding padStart
  • Remove countdown div if the next event is not found
  • Make UTC, instead of local (i don't know how i forgot about timezones)
  • Fix header blur
  • Center menu items in menu dropdown
  • Add 2024 page (not implemented yet)

@1ceit 1ceit requested a review from ErikBoesen December 20, 2024 00:08
@1ceit 1ceit requested a review from MyaTaheri December 20, 2024 16:35
@@ -93,7 +93,7 @@ team:
- name: "Eleanor Johnson"
year: "'25"
role: "🔧 Mechanic 🔧"
image: "/images/team/placeholder.png"
image: "/images/team/wendy-abstone.png"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a different person's name

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

she wanted a picture but didn't want to make one. She went through the catalogue and picked Wendy.

@@ -11,7 +11,7 @@ <h5>We love our sponsors!</h5>
<td><a href="http://www.baroodycamps.com/ " target="_blank"><img src="/images/sponsors/baroodycamps.png"></a></td>
<td><a href="https://ghaasfoundation.org/" target="_blank"><img src="/images/sponsors/gene-haas-foundation.png"></a></td>
<td><a href="https://krobothconsulting.com/" target="_blank"><img src="/images/sponsors/kroboth-consulting.png"></a></td>
<td><a href="https://alarm.com" target="_blank"><img src="/images/sponsors/Alarmdotcom.png"></a></td>
<td><a href="https://alarm.com" target="_blank"><img src="/images/sponsors/ADCLogo_horizontal.png"></a></td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be nice to rename this image to match the format used by the other logos

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But not a big deal

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sorry I just dragged it from the zip with out editing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify why there's tons of identical images here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are a frames of an animation.

js/2024.js Outdated Show resolved Hide resolved
js/2024.js Outdated Show resolved Hide resolved
} else if (frame < startTitleFrame) {
title.style.opacity = '1';
} else if (frame > endTitleFrame) {
title.style.opacity = '0';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is repeated from a few lines earlier, I think

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had the first as a place holder and didn't remove it.

Copy link
Member

@ErikBoesen ErikBoesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval was accidental but it's almost ready

1ceit added 2 commits January 9, 2025 13:12
Remove unnecessary if statements in animateTitle()
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants