-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix Countdown #623
base: master
Are you sure you want to change the base?
Fix Countdown #623
Conversation
1ceit
commented
Dec 20, 2024
•
edited
Loading
edited
- Fix countdown by adding padStart
- Remove countdown div if the next event is not found
- Make UTC, instead of local (i don't know how i forgot about timezones)
- Fix header blur
- Center menu items in menu dropdown
- Add 2024 page (not implemented yet)
@@ -93,7 +93,7 @@ team: | |||
- name: "Eleanor Johnson" | |||
year: "'25" | |||
role: "🔧 Mechanic 🔧" | |||
image: "/images/team/placeholder.png" | |||
image: "/images/team/wendy-abstone.png" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a different person's name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
she wanted a picture but didn't want to make one. She went through the catalogue and picked Wendy.
@@ -11,7 +11,7 @@ <h5>We love our sponsors!</h5> | |||
<td><a href="http://www.baroodycamps.com/ " target="_blank"><img src="/images/sponsors/baroodycamps.png"></a></td> | |||
<td><a href="https://ghaasfoundation.org/" target="_blank"><img src="/images/sponsors/gene-haas-foundation.png"></a></td> | |||
<td><a href="https://krobothconsulting.com/" target="_blank"><img src="/images/sponsors/kroboth-consulting.png"></a></td> | |||
<td><a href="https://alarm.com" target="_blank"><img src="/images/sponsors/Alarmdotcom.png"></a></td> | |||
<td><a href="https://alarm.com" target="_blank"><img src="/images/sponsors/ADCLogo_horizontal.png"></a></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be nice to rename this image to match the format used by the other logos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But not a big deal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah sorry I just dragged it from the zip with out editing.
images/Note/0013.png
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you clarify why there's tons of identical images here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are a frames of an animation.
} else if (frame < startTitleFrame) { | ||
title.style.opacity = '1'; | ||
} else if (frame > endTitleFrame) { | ||
title.style.opacity = '0'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is repeated from a few lines earlier, I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had the first as a place holder and didn't remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval was accidental but it's almost ready
Remove unnecessary if statements in animateTitle()