-
-
Notifications
You must be signed in to change notification settings - Fork 87
Use subscribe flag to get and put contract requests #1462
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iduartgomez
reviewed
Mar 9, 2025
This will be very useful, it means a single API command to initiate syncing of contracts with the network bi-directionally. |
@netsirius I merged this branch into my working River branch as it should simplify the state synchronization - I should probably have checked with you first to see if it's functional enough for me to use experimentally? |
This was referenced Mar 14, 2025
f57729a
to
788f0a7
Compare
13ed7c8
to
86dd245
Compare
# Conflicts: # stdlib # Conflicts: # stdlib
45109ca
to
0822903
Compare
0822903
to
0e544d1
Compare
7859aa5
to
4f5f218
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
subscribe
field to various contract operations, ensuring that the subscription status is consistently handled throughout the codebase. The changes span multiple files and functions, adding thesubscribe
field where necessary and updating function calls and state management accordingly.Key changes include:
Addition of
subscribe
field:start_op
function incrates/core/src/operations/get.rs
to include thesubscribe
parameter.GetState
enum incrates/core/src/operations/get.rs
to include thesubscribe
field in relevant states. [1] [2]subscribe
field to various function calls and state initializations incrates/core/src/client_events.rs
andcrates/core/src/contract/executor.rs
. [1] [2] [3] [4] [5] [6] [7] [8] [9]Consistent handling of
subscribe
in operations:subscribe
field is correctly passed and utilized in theGetOp
andPutOp
operations. [1] [2] [3] [4] [5] [6]crates/core/src/client_events.rs
to include thesubscribe
field. [1] [2] [3]Subscription request handling:
crates/core/src/node.rs
andcrates/core/src/operations.rs
to handle thesubscribe
field appropriately. [1] [2]These changes ensure that the subscription status is consistently managed across different parts of the system, improving the reliability and maintainability of the code.