Fixing errors for CM6 code input. #331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 10, 2024 22:57
Removing {signal} reference to listener which seems to reference an
already removed object.
|
Thank you for looking into this! So this fixed it? I'll have to check what this piece of code was doing first. |
|
I think so. I've build and run it in Firefox and Chromium and I can edit the same code field multiple times in Jupyter notebooks. I'm not great with JS so I have no idea what the side effects of what I've done are, but nothing catastrophic seems to be happening. |
fregante
requested changes
Nov 11, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing error where once a CM6 field has been opened it can't be opened again without a page refresh, as documented in #296.