-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Expression Presets v2 #456
Conversation
Add support for the new expression preset system. Co-authored-by: Pablo Gil <pgilfernandez@gmail.com>
- hover and focus fixes - fix path on import/save - sort presets in combo box Co-authored-by: Pablo Gil <pgilfernandez@gmail.com>
Will do some final tests, then merge this by the end of the day. |
Bug fix.
I have just tried the export and meta dialog option and the way you sorted it feels unnatural:
I would rather do this way:
I would leave file name and folder for last step and I would omit the success popup, it is supposed to be fine unless there is something wrong, then is when I would show an Error popup... what do you think? BTW, I would even use the "save" button as this meta data editor where you could even change the name of the preset. |
Check latest commit (6d5695a), did some improvements. |
Much better, I like it. |
I have just created a PR proposal for tweaking the dialog instead of asking you to do it... #466 |
Replacement for PR #441, clean git history.