Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expression Presets v2 #456

Merged
merged 7 commits into from
Mar 2, 2025
Merged

Expression Presets v2 #456

merged 7 commits into from
Mar 2, 2025

Conversation

rodlie
Copy link
Member

@rodlie rodlie commented Feb 16, 2025

Replacement for PR #441, clean git history.

rodlie and others added 3 commits February 16, 2025 20:20
Add support for the new expression preset system.

Co-authored-by: Pablo Gil <pgilfernandez@gmail.com>
@rodlie rodlie added enhancement New feature or request expressions labels Feb 16, 2025
@rodlie rodlie added this to the 1.0.0 milestone Feb 16, 2025
@rodlie rodlie mentioned this pull request Feb 16, 2025
- hover and focus fixes
- fix path on import/save
- sort presets in combo box

Co-authored-by: Pablo Gil <pgilfernandez@gmail.com>
@rodlie
Copy link
Member Author

rodlie commented Feb 23, 2025

Will do some final tests, then merge this by the end of the day.

@rodlie
Copy link
Member Author

rodlie commented Feb 24, 2025

Added a edit meta dialog when exporting.
Screenshot 2025-02-24 at 13 40 39

@pgilfernandez
Copy link

Added a edit meta dialog when exporting. Screenshot 2025-02-24 at 13 40 39

Why don't make it available too for installed Preset? this way you can just edit the meta

@pgilfernandez
Copy link

I have just tried the export and meta dialog option and the way you sorted it feels unnatural:

  1. press "export button
  2. choose a name and folder in your file browser
  3. meta data dialog
  4. success popup

I would rather do this way:

  1. press "export button
  2. meta data dialog
  3. choose a name and folder in your file browser

I would leave file name and folder for last step and I would omit the success popup, it is supposed to be fine unless there is something wrong, then is when I would show an Error popup...

what do you think?

BTW, I would even use the "save" button as this meta data editor where you could even change the name of the preset.

@rodlie
Copy link
Member Author

rodlie commented Feb 24, 2025

Check latest commit (6d5695a), did some improvements.

@pgilfernandez
Copy link

Check latest commit (6d5695a), did some improvements.

Much better, I like it.
Would you consider opening the meta data popup when pressing "save" button? that way you could always edit not just the name and bindings/script/definitions. If not then it's perfect, I don't find any strange behavior 😄

@pgilfernandez
Copy link

I have just created a PR proposal for tweaking the dialog instead of asking you to do it... #466

@rodlie rodlie merged commit de7723d into main Mar 2, 2025
6 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants