add faster safe rust variant that does not drop needlessly #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the split and merge parts, calls to drop were inserted to delete options that had been taken, ie were already none. Thus the calls to drop would always conclude they didn't need to drop, but this would waste computational resources. Using the swap and forget pattern, we can safely inform the compiler that the taken node does not actually need to be freed.
frol
reviewed
May 18, 2018
rust/src/swap_forget.rs
Outdated
| if let Some(mut orig_node) = orig { | ||
| if orig_node.x < value { | ||
| let mut split_pair = split_binary(orig_node.right.take(), value); | ||
| ::std::mem::swap(&mut orig_node.right, &mut split_pair.0); |
There was a problem hiding this comment.
::std:: can be dropped here, right?
There was a problem hiding this comment.
Right, I've updated to fix this.
|
@vbarrielle Nice trick! Thank you! This dropped the execution time from 0.37s to 0.24s while still keeping the safety guarantees! |
frol
added a commit
that referenced
this pull request
May 18, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the split and merge parts, calls to drop were inserted to delete
options that had been taken, ie were already none. Thus the calls to
drop would always conclude they didn't need to drop, but this would waste
computational resources. Using the swap and forget pattern, we can
safely inform the compiler that the taken node does not actually need to
be freed.
This significantly decreased the runtime on my machine (from ~0.5s for the idiomatic version down to ~0.3s for the new version).