Refactoring: move test-case macro to separate subcrate #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frondeus
reviewed
Apr 24, 2022
| output.into() | ||
| } | ||
| pub use test_case_macros::test_case; | ||
| pub use test_case_macros::test_case as case; |
There was a problem hiding this comment.
I'm not sure if I follow why this alias has been made
There was a problem hiding this comment.
I thought we may consider adding this as test_case is reserved by custom_test_frameworks and may induce some issues and confusion in the future. But in reality, right now it's just an extra option.
frondeus
approved these changes
Apr 25, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consists of:
crates/test-case-macroscaseas legal test_case attribute name