-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use network_status instead of homescreen #119
Conversation
Use network_status to check if System is armed or disarmed
blinkpy/sync_module.py
Outdated
@@ -114,6 +117,7 @@ def refresh(self, force_cache=False): | |||
self.events = self.get_events() | |||
self.videos = self.get_videos() | |||
self.homescreen = api.request_homescreen(self.blink) | |||
self.network_info = api.request_network_status(self.blink,self.network_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (82 > 79 characters)
missing whitespace after ','
blinkpy/sync_module.py
Outdated
@@ -88,6 +89,8 @@ def start(self): | |||
|
|||
self.homescreen = api.request_homescreen(self.blink) | |||
|
|||
self.network_info = api.request_network_status(self.blink,self.network_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (82 > 79 characters)
missing whitespace after ','
blinkpy/sync_module.py
Outdated
@@ -114,6 +118,8 @@ def refresh(self, force_cache=False): | |||
self.events = self.get_events() | |||
self.videos = self.get_videos() | |||
self.homescreen = api.request_homescreen(self.blink) | |||
self.network_info = api.request_network_status(self.blink, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trailing whitespace
blinkpy/sync_module.py
Outdated
@@ -88,6 +89,9 @@ def start(self): | |||
|
|||
self.homescreen = api.request_homescreen(self.blink) | |||
|
|||
self.network_info = api.request_network_status(self.blink, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trailing whitespace
blinkpy/sync_module.py
Outdated
@@ -114,6 +117,7 @@ def refresh(self, force_cache=False): | |||
self.events = self.get_events() | |||
self.videos = self.get_videos() | |||
self.homescreen = api.request_homescreen(self.blink) | |||
self.network_info = api.request_network_status(self.blink, self.network_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (83 > 79 characters)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix this:
self.network_info = api.request_network_status(self.blink, self.network_id) | |
self.network_info = api.request_network_status(self.blink, | |
self.network_id) |
The |
Co-Authored-By: md-reddevil <16707502+md-reddevil@users.noreply.github.com>
The test fix I gave you was incorrect, I misread the code. I just went in and fixed it myself and cleaned up the linting error, so it's ready to merge now. Thanks for the continued contributions! |
Use network_status to check if System is armed or disarmed
Description:
Related issue (if applicable): fixes #
fixes #118
Checklist:
tox
run successfully PR cannot be meged unless tests pass