Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removed 'reauth' key from login payload #308

Merged
merged 1 commit into from
Jun 14, 2020
Merged

Removed 'reauth' key from login payload #308

merged 1 commit into from
Jun 14, 2020

Conversation

fronzbot
Copy link
Owner

Description:

Setting the 'reauth' key to 'false' in the login payload seems to have stopped triggering 24hr 2FA key refreshes (that seemed to be ignored anyways). Longer term testing is required to verify the fix.

Related issue (if applicable): fixes #279

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@codecov
Copy link

codecov bot commented Jun 14, 2020

Codecov Report

Merging #308 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #308   +/-   ##
=======================================
  Coverage   82.88%   82.88%           
=======================================
  Files           8        8           
  Lines         923      923           
=======================================
  Hits          765      765           
  Misses        158      158           
Flag Coverage Δ
#unittests 82.88% <ø> (ø)
Impacted Files Coverage Δ
blinkpy/api.py 61.29% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8c78fb...3805a41. Read the comment docs.

@fronzbot fronzbot merged commit 6a7eff6 into dev Jun 14, 2020
@fronzbot fronzbot deleted the fix-extra-reauth branch June 14, 2020 14:46
@fronzbot fronzbot mentioned this pull request Jul 20, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New 2FA email every 24hrs
1 participant