Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Broke out homescreen call to prevent back-to-back api calls #313

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

fronzbot
Copy link
Owner

Description:

For implementations with no_prompt=True back-to-back API calls when looking for mini cameras caused a BlinkSetupError to be raised. These calls have been separated and this bug should be fixed now.

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@codecov
Copy link

codecov bot commented Jun 16, 2020

Codecov Report

Merging #313 into dev will decrease coverage by 0.17%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #313      +/-   ##
==========================================
- Coverage   82.88%   82.70%   -0.18%     
==========================================
  Files           8        8              
  Lines         923      925       +2     
==========================================
  Hits          765      765              
- Misses        158      160       +2     
Flag Coverage Δ
#unittests 82.70% <71.42%> (-0.18%) ⬇️
Impacted Files Coverage Δ
blinkpy/blinkpy.py 79.09% <71.42%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0ea056...dff0746. Read the comment docs.

@fronzbot fronzbot merged commit d0fa303 into dev Jun 16, 2020
@fronzbot fronzbot deleted the improve-mini-extraction branch June 16, 2020 17:54
@fronzbot fronzbot mentioned this pull request Jul 20, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant