Fixed import error for pip version 10 #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 9, 2018
setup.py
Outdated
| # https://stackoverflow.com/a/49867265 | ||
| try: # pip > 10 | ||
| from pip._internal.req import parse_requirements | ||
| except ImportError: # pip < 10 |
There was a problem hiding this comment.
at least two spaces before inline comment
setup.py
Outdated
| from pip.req import parse_requirements | ||
| # Fixes import error due to breaking change in pip 10 | ||
| # https://stackoverflow.com/a/49867265 | ||
| try: # pip > 10 |
There was a problem hiding this comment.
at least two spaces before inline comment
houndci-bot
reviewed
May 9, 2018
setup.py
Outdated
| # https://stackoverflow.com/a/49867265 | ||
| try: # pip > 10 | ||
| from pip._internal.req import parse_requirements | ||
| except ImportError: # pip < 10 |
There was a problem hiding this comment.
inline comment should start with '# '
setup.py
Outdated
| from pip.req import parse_requirements | ||
| # Fixes import error due to breaking change in pip 10 | ||
| # https://stackoverflow.com/a/49867265 | ||
| try: # pip > 10 |
There was a problem hiding this comment.
inline comment should start with '# '
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With pip10, import from
pip.reqfor theparse_requirementsfunctions is deprecated and replaced withpip._internals.reqChecklist:
toxrun successfully PR cannot be meged unless tests pass