Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Misc doorbell fixes #623

Merged
merged 2 commits into from
Sep 11, 2022
Merged

Misc doorbell fixes #623

merged 2 commits into from
Sep 11, 2022

Conversation

jeffothy
Copy link
Contributor

@jeffothy jeffothy commented Sep 6, 2022

Description:

  1. Network ID for doorbell accessed via sync object
  2. String split and join for protocol replacement swallows the port colo (i.e. "immis://host:port/path" changes to "rtsps://hostport/path") so use a more explicit replacement instead.

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Merging #623 (c401965) into dev (1a75592) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##              dev     #623      +/-   ##
==========================================
- Coverage   86.84%   86.81%   -0.03%     
==========================================
  Files           8        8              
  Lines        1064     1062       -2     
==========================================
- Hits          924      922       -2     
  Misses        140      140              
Flag Coverage Δ
unittests 86.81% <66.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
blinkpy/camera.py 84.26% <66.66%> (-0.16%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@fronzbot
Copy link
Owner

Looks good, thanks for the PR!

@fronzbot fronzbot merged commit d83ad0f into fronzbot:dev Sep 11, 2022
@fronzbot fronzbot mentioned this pull request Jan 30, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants