Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I have a micro-service which I have been using to get blink camera armed and battery status. I'd like to add to that micro-service the ability to 1. list videos, and 2. download videos. I checked, and download_videos had the components I was looking for, but they were all wrapped up together. With this PR I'm breaking out two methods: 1. get_videos_metadata, and 2. do_http_get. The download_videos now consists of 1. forcing
camera
into a list, a call to get_videos_metadata, and then calling the download parser. The download parser was only modified to call do_http_get instead of downloading directly, and moving the calculation of clip_address into do_http_get.Related issue (if applicable): N/A
Checklist:
tox
run successfully PR cannot be meged unless tests pass