Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix night vision toggling for older devices (owl) #756

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

cocasema
Copy link

Fixes: #755

Description:

Reverts "camera config update" API path to the original value (before refactoring in #717)

Logs:

DEBUG:blinkpy.api:Making POST request to https://rest-u012.immedia-semi.com/api/v1/accounts/A/networks/N/owls/C/update: {"illuminator_enable": "on"}
<ClientResponse(https://rest-u012.immedia-semi.com/api/v1/accounts/A/networks/N/owls/C/update) [404 Not Found]>
DEBUG:blinkpy.api:Making POST request to https://rest-u012.immedia-semi.com/api/v1/accounts/A/networks/N/owls/C/config: {"illuminator_enable": "on"}
<ClientResponse(https://rest-u012.immedia-semi.com/api/v1/accounts/A/networks/N/owls/C/config) [200 OK]>

Tests:

 tests/test_api.py ✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓                                                             10% █         
 tests/test_auth.py ✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓                                                         21% ██▎       
 tests/test_blink_functions.py ✓✓✓✓✓✓✓✓✓✓✓✓                                                     29% ██▉       
 tests/test_blinkpy.py ✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓                                            46% ████▋     
 tests/test_camera_functions.py ✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓                                             58% █████▊    
 tests/test_cameras.py ✓✓✓✓✓✓✓✓✓                                                                63% ██████▍   
 tests/test_doorbell_as_sync.py ✓✓                                                              65% ██████▌   
 tests/test_errors.py ✓                                                                         65% ██████▌   
 tests/test_mini_as_sync.py ✓✓                                                                  66% ██████▋   
 tests/test_sync_functions.py ✓✓✓✓✓✓✓                                                           71% ███████▏  
 tests/test_sync_module.py ✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓✓                                  92% █████████▎
 tests/test_util.py ✓✓✓✓✓✓✓✓✓✓✓✓✓                                                              100% ██████████

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #756 (84818c5) into dev (cb59b76) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #756   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files           8        8           
  Lines        1404     1404           
=======================================
  Hits         1399     1399           
  Misses          5        5           
Flag Coverage Δ
unittests 99.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
blinkpy/api.py 100.00% <ø> (ø)

@fronzbot fronzbot merged commit f4029eb into fronzbot:dev Aug 18, 2023
@fronzbot
Copy link
Owner

👍 thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Night vision toggling is broken for older devices (owl)
2 participants