Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Address not awaited warning #838

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Jan 2, 2024

Description:

Due to a patching "error" the tests were throwing a never awaited warning. The return value should not have been an awaitable object.

Related issue (if applicable): fixes #

Checklist:

  • Local tests with tox run successfully PR cannot be meged unless tests pass
  • Changes tested locally to ensure platform still works as intended
  • Tests added to verify new code works

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58a16c4) 99.86% compared to head (72ca60b) 99.86%.
Report is 11 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #838   +/-   ##
=======================================
  Coverage   99.86%   99.86%           
=======================================
  Files           8        8           
  Lines        1453     1453           
=======================================
  Hits         1451     1451           
  Misses          2        2           
Flag Coverage Δ
unittests 99.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fronzbot fronzbot merged commit 8e4678a into fronzbot:dev Jan 2, 2024
@mkmer mkmer deleted the Fix-never-await-warnings branch January 3, 2024 12:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants