-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
1488 #694
Comments
Can you reproduce when running |
can you run Also is that code open source? If so, can you link it? If not, can you share a snippet of it with the cyrillic characters? I'll try to repro |
Yes, it's open source, here's the repo |
$ prettierd --debug-info src/dict/index.ts
prettierd 0.25.2
prettier version: 3.1.1
Loaded from: /home/gooseob/projects/taraskevizer/node_modules/prettier/index.cjs |
It's the same situation for Japanese characters, can reproduce with |
It's not _really_ a new dependency as prettier already depends on it, but let's bring it in. I suspect that users are running into weird encoding issues in #694 (and maybe #698). Rather than spending too much time on this, I'm just taking a shortcut: users confirm that they cannot reproduce the issue in `prettier`, so let's read stdin the same `prettier` does :)
It's not _really_ a new dependency as prettier already depends on it, but let's bring it in. I suspect that users are running into weird encoding issues in #694 (and maybe #698). Rather than spending too much time on this, I'm just taking a shortcut: users confirm that they cannot reproduce the issue in `prettier`, so let's read stdin the same `prettier` does :)
It's not _really_ a new dependency as prettier already depends on it, but let's bring it in. I suspect that users are running into weird encoding issues in #694 (and maybe #698). Rather than spending too much time on this, I'm just taking a shortcut: users confirm that they cannot reproduce the issue in `prettier`, so let's read stdin the same `prettier` does :)
Thanks for the added details. Can you try the latest release? |
Thanks for confirming! I'll keep digging into it. |
The bug seems similar to GooseOb/taraskevizer#5. So there might be a problem with |
Oh, I see you changed the implementation of get-stdin and I do not see the bug now. Seems like it helped |
No, it didn't, I still get this characters :) |
Any fix? |
Worked fine until the moment when it started to produce
�
in random places. On every save it adds��
to the same place (start of the 1488 line).Using lazy.nvim with null-ls. Plugin is installed via Mason.
FIle encoding is
utf-8
.Using cyrillic characters.
Working on WSL2 Ubuntu.
Isn't reproducing with
prettier
.The text was updated successfully, but these errors were encountered: