Skip to content
This repository has been archived by the owner on Oct 31, 2021. It is now read-only.

XMLDoc comments unusably slow #1072

Closed
dbwz8 opened this issue Aug 8, 2015 · 5 comments
Closed

XMLDoc comments unusably slow #1072

dbwz8 opened this issue Aug 8, 2015 · 5 comments

Comments

@dbwz8
Copy link

dbwz8 commented Aug 8, 2015

When typing ///< it can literally take a minute or two before the comment insertion happens (typically it's more like several seconds). This is long enough to give up, go somewhere else in the file and then all of a sudden have the comment inserted completely at random. Very bad.

@vasily-kirichenko
Copy link
Contributor

@dungpa We only parse current file here https://github.com/fsprojects/VisualFSharpPowerTools/blob/master/src/FSharpVSPowerTools.Core/XmlDocParser.fs#L141 It should be very fast. So, I suspect we are waiting in Checker queue until Parse and Check, triggered by other features, finishes. No idea what to do with it. /cc @dsyme

@dungpa
Copy link
Contributor

dungpa commented Aug 13, 2015

@dbwz8 How big is the file that you observe the slow down? Does this happen right after opening a Visual Studio session (i.e. in the low traffic scenario)?

@dbwz8
Copy link
Author

dbwz8 commented Aug 13, 2015

Here’s what we see:

  1. VS Just opened on a single small file… instantaneous
  2. VS Just opened with lots of tabs on a small file… instantaneous
  3. VS Just opened on a large file (3000 lines)… 10 seconds
  4. Doing the small file after the big file…. 5 seconds
  5. Doing the large file again… 20 seconds

It definitely gets worse the longer you’re in VS, however sometimes it’s instantaneous even after long editing sessions on large files. Very unpredictable.

From: Anh-Dung Phan [mailto:notifications@github.com]
Sent: Thursday, August 13, 2015 7:11 AM
To: fsprojects/VisualFSharpPowerTools VisualFSharpPowerTools@noreply.github.com
Cc: Dave Wecker dbwz8@hotmail.com
Subject: Re: [VisualFSharpPowerTools] XMLDoc comments unusably slow (#1072)

@dbwz8 https://github.com/dbwz8 How big is the file that you observe the slow down? Does this happen right after opening a Visual Studio session (i.e. in the low traffic scenario)?


Reply to this email directly or view it on GitHub #1072 (comment) . https://github.com/notifications/beacon/AKEAqZMiG-wrTqo2kn958jDFAVnQhr71ks5onJ0GgaJpZM4Fn71Z.gif

@dungpa
Copy link
Contributor

dungpa commented Oct 17, 2015

@dbwz8 Apologize for the slow reply.

Could you try a recent build with a potential fix for the issue https://ci.appveyor.com/project/dungpa/visualfsharppowertools/build/2.2.0-a1510171153?

Due to historical reasons, XmlDoc generation wasn't cached properly as other features. It has been corrected in #1173 and #1177.

Thank you.

@vasily-kirichenko
Copy link
Contributor

@dbwz8 If you still experience any issues with XML Doc generation, reopen this issue or create another one.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

3 participants