Better support for AssemblyMetadata in AssemblyInfoHelper - closes #683 #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change 'string list' in favor of '(string * string) list'
|
That's breaking, but I think @jchannon is the only one using it right now ;-) |
|
👍 |
|
please tell me when it's ready to merge |
replaceAttribute doesn't handle AssemblyMetadata very well, it needs a more sophisticated function.
inosik
force-pushed
the
assemblymetadata-support
branch
from
b297fd0 to
222d4a9
Compare
|
Alright, I think I'm done here. Maybe we should merge |
forki
added a commit
that referenced
this pull request
Mar 22, 2015
Better support for AssemblyMetadata in AssemblyInfoHelper - closes #683
|
thanks. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced a new function for handling AssemblyMetadata attributes.
Didn't write tests yet, just played around with that in FSI.
What do you say @jchannon?