This repository has been archived by the owner on Oct 31, 2021. It is now read-only.
DepthTagger retrieves project checker options from ProjectProvider instead of getting it from FSharpChecker #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stead of getting it from FSharpChecker
|
Also I revern |
| let dte = serviceProvider.GetService<EnvDTE.DTE, SDTE>() | ||
| let! doc = dte.GetCurrentDocument doc.FilePath | ||
| let! project = projectFactory.CreateForDocument buffer doc | ||
| let! opts = languageService.GetProjectCheckerOptions project |> liftAsync |
There was a problem hiding this comment.
Are the results of this saved? Or are you recomputing the options on each change of the document? Just checking.
There was a problem hiding this comment.
Yes, ProjectFactory is actually a cache of project options. This is what we use in all other features.
|
I think similar refactoring should be done for |
|
all done, thanks |
vasily-kirichenko
added a commit
that referenced
this pull request
Oct 17, 2015
…-get-opts DepthTagger retrieves project checker options from ProjectProvider instead of getting it from FSharpChecker
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.