Convert Units Logic Bug Fix #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-kieu
requested review from
n6171028,
BenCurran98,
MeganDawson42,
mazadbakht and
zqiaofugro
MeganDawson42
approved these changes
Jun 4, 2024
BenCurran98
approved these changes
Jun 4, 2024
mazadbakht
approved these changes
Jun 5, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the logic restrictions in
convert_units!as we are passing through conversion kwargs overrides toconversion_from_vlrsto handle conversion.Description
Fix the bug where when calling
load_pointcloudwith kwargsconvert_x_y_unitsandconvert_z_unitsboth set tomissing, the point cloud returned would not be in metres. That is, no unit conversion occured, and the point cloud would be returned in the original units.Types of Changes