VLR String Description Inconsistency #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BenCurran98 <b.curran@fugro.com>
BenCurran98
requested review from
n6171028,
MeganDawson42,
mazadbakht,
zqiaofugro and
i-kieu
n6171028
reviewed
Feb 13, 2025
| @@ -20,7 +20,7 @@ end | |||
| Write a string `str` to an IO channel `io`, writing exactly `nb` bytes (padding if `str` is too short) | |||
| """ | |||
| function writestring(io, str::AbstractString, nb::Integer) | |||
| n = length(str) | |||
| n = Base.sizeof(str) | |||
There was a problem hiding this comment.
This is very tricky...how you found it?
There was a problem hiding this comment.
Printing a bunch of stuff out over several days 😆
n6171028
approved these changes
Feb 13, 2025
MeganDawson42
approved these changes
Feb 13, 2025
|
|
||
| # test with special characters whose ASCII encoding is > 0x80, meaning their number of "code units" will be 2, not one | ||
| # see here for more details: https://docs.julialang.org/en/v1/manual/strings/#Unicode-and-UTF-8 | ||
| str = "aβcd" |
There was a problem hiding this comment.
missed opportunity to add emoticons?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix inconsistency in writestring due to unicode encoding
Description
This fixes a bug that crops up sometimes when reading VLRs and EVLRs from a LAS file whose descriptions contain unicode characters with 2 bytes of length instead of 1. Basically, when we write a VLR description, we call
writestring(io, description, 32)(since as per the LAS spec, the description should be 32 bytes in length). However,writestringwould add a buffer to the string (trailing "\0" 's) iflength(description)is < 32, even ifsize(description) == 32, meaning we're adding extra bytes to the file causing some corruptions down the line.This turns into a simple fix, just replacing
lengthwithsizeinwritestringTypes of Changes
Review
List of tasks the reviewer must do to review the PR