Extension of IFn #106
Merged
Extension of IFn #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @tcsavage Thanks for you work. Independently of the circumstances, I prefer the implemented approach to the haskell one. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements semigroup, monoid, functor, applicative and monad for IFn.
I asked in #52 which semigroup. monoid implementation would be preferred but after attempting to implement Haskell's default, I'm not sure it's possible with the context system (certainly not in a nice way). So I implemented
mappendascompandmemptyasidentityinstead which has the added advantage be being much simpler.