Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unstable special rules #358

Closed
spirillen opened this issue Mar 11, 2024 · 1 comment
Closed

Unstable special rules #358

spirillen opened this issue Mar 11, 2024 · 1 comment

Comments

@spirillen
Copy link
Contributor

As I was reporting to @mitchellkrogza in https://github.com/mitchellkrogza/Phishing.Database/issues/840 it comes to my attention that the special rules are inconsequential in the test result.

IE: these two are by visiting the domains HTTP 410, which should have been switched to down by rule, but are marked ACTIVE

broomy-ropes.000webhostapp.com
brush-fire-binders.000webhostapp.com

image

spirillen added a commit to foreign-affairs/PyFunceble-docs that referenced this issue Mar 11, 2024
funilrys pushed a commit that referenced this issue Mar 26, 2024
While working with #358, #354 & https://github.com/mitchellkrogza/Phishing.Database/issues/840 

I found that the hosting company also uses the HTTP code 428 for disabled (Website is archived.) 

Example URI

```css
http://httpmwankaiwqkcom.000webhostapp.com/
http://https244577889078564546464534353date.000webhostapp.com/
```
funilrys added a commit that referenced this issue Mar 26, 2024
This patch touches #358.

Indeed, before this patch, the special rules may have been
unstable when testing domains (not URL).
This patch fixes the issue by ensuring that our http_status_code
lookup is always done against a URL - if the testeted subject is
not an http(s) URL.

Contributors:
  * @spirillen
@funilrys
Copy link
Owner

For those who are not into Python.

  • [1,2,3] -> list
  • {1,2,3} -> set
  • (1,2,3) -> tuple

cc: @spirillen

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants