-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Week 4 Blogpost #809
Week 4 Blogpost #809
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JoaoDell,
You blogpost generated well locally. I just had the below comments!
|
||
Welcome again to another weekly blogpost! Today, let's talk about the importance of guidance throughout a project. | ||
|
||
This Last Week's Effort |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence seem a bit odd to me.
You can either use This Week's Effort
or Last Week's Effort
.
This Week's Goals | ||
----------------- | ||
Now, with the FBO working, I plan to finally *render* something to it. For this week, I plan to come back to my original plan and | ||
experiment with simple shaders just as a a proof of concept that the FBO will be really useful for this project. I hope the road is less |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a
repeated twice in just as a a proof
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @JoaoDell, glad you were able to fix the problem, great teamwork!
I just have one minor comment, but everything else looks good to me.
|
||
FBO = vtk.vtkOpenGLFramebufferObject() | ||
|
||
manager.window.SetOffScreenRendering(True) # so the window don't show up, but important for later as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't
=> doesn't
@ganimtron-10 @tvcastillod thanks for the reviews, just changed what you pointed out :) |
Codecov Report
@@ Coverage Diff @@
## master #809 +/- ##
=======================================
Coverage 84.43% 84.43%
=======================================
Files 43 43
Lines 10274 10274
Branches 1393 1393
=======================================
Hits 8675 8675
Misses 1239 1239
Partials 360 360 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks to the reviewers and @JoaoDell.
small note for the future blog post: Try to do shorter sentences. Check general literature in english. Short sentences make it easier to read. The "last week effort" section is a bit hard read.
Merging
Hello guys, here is my week 4 blogpost:
![image](https://private-user-images.githubusercontent.com/61475630/248938621-cb4eff51-1d0d-4256-b9d9-fdce6752bd75.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyMjI2MTgsIm5iZiI6MTczOTIyMjMxOCwicGF0aCI6Ii82MTQ3NTYzMC8yNDg5Mzg2MjEtY2I0ZWZmNTEtMWQwZC00MjU2LWI5ZDktZmRjZTY3NTJiZDc1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDIxMTgzOFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQzOTM0OTc5MjM1MDEwYjU0NzRlMWE4YzE3ZDhiOWY1NTVkNjMzZWY3ZGUxYTAxODVmMzhhZTMzMTllNGVmMGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.S3VF8wtywkjek4oDpcGCBXHrOttXRmlFQQ59uAShfa4)