Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Week 4 Blogpost #809

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Week 4 Blogpost #809

merged 2 commits into from
Jun 30, 2023

Conversation

JoaoDell
Copy link
Contributor

Hello guys, here is my week 4 blogpost:
image

Copy link
Contributor

@ganimtron-10 ganimtron-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JoaoDell,
You blogpost generated well locally. I just had the below comments!


Welcome again to another weekly blogpost! Today, let's talk about the importance of guidance throughout a project.

This Last Week's Effort
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence seem a bit odd to me.
You can either use This Week's Effort or Last Week's Effort.

This Week's Goals
-----------------
Now, with the FBO working, I plan to finally *render* something to it. For this week, I plan to come back to my original plan and
experiment with simple shaders just as a a proof of concept that the FBO will be really useful for this project. I hope the road is less
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a repeated twice in just as a a proof

Copy link
Contributor

@tvcastillod tvcastillod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JoaoDell, glad you were able to fix the problem, great teamwork!
I just have one minor comment, but everything else looks good to me.


FBO = vtk.vtkOpenGLFramebufferObject()

manager.window.SetOffScreenRendering(True) # so the window don't show up, but important for later as well
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't => doesn't

@JoaoDell
Copy link
Contributor Author

@ganimtron-10 @tvcastillod thanks for the reviews, just changed what you pointed out :)

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #809 (5a42c96) into master (3d53e48) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #809   +/-   ##
=======================================
  Coverage   84.43%   84.43%           
=======================================
  Files          43       43           
  Lines       10274    10274           
  Branches     1393     1393           
=======================================
  Hits         8675     8675           
  Misses       1239     1239           
  Partials      360      360           

Copy link
Contributor

@skoudoro skoudoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks to the reviewers and @JoaoDell.

small note for the future blog post: Try to do shorter sentences. Check general literature in english. Short sentences make it easier to read. The "last week effort" section is a bit hard read.

Merging

@skoudoro skoudoro merged commit 02b95cb into fury-gl:master Jun 30, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants