Android - Optimization #392
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added options for optimization:
```
"Android": {
"Optimize": {
"MinifyEnabled": true,
"ShrinkResources": true,
"DefaultAndroidProGuard": "proguard-android-optimize.txt",
"PrependRulesFile": "proguard-rules-prepend.pro",
"AppendRulesFile": "proguard-rules-append.pro"
},
...
```
Default android proguard rules(proguard-android.txt) are applied when not specified
```
"Android": {
"Optimize": {
"MinifyEnabled": true,
"ShrinkResources": true
},
...
```
Can add custom proguard rules before or after the main generated class rules:
```
"Android": {
"Optimize": {
"MinifyEnabled": true,
"ShrinkResources": true,
"PrependRulesFile": "proguard-rules-prepend.pro",
"AppendRulesFile": "proguard-rules-append.pro"
},
...
```
Create "proguard-rules-prepend.pro" in root of Project folder:
e.g.
MyApp/MainView.ux
MyApp/proguard-rules-prepend.pro
...
proguard-rules-prepend.pro
```
-keepattributes *Annotation*
-keepattributes Exceptions
-keepattributes InnerClasses
-keepattributes Signature
-keepattributes SourceFile,LineNumberTable
```
mortend
reviewed
Apr 2, 2021
| @@ -79,6 +79,9 @@ | |||
| <Set Outputs.AAR="app/build/outputs/aar/app-@(Build.Configuration:ToLower).aar" /> | |||
| <Set Outputs.APK="app/build/outputs/apk/@(Build.Configuration:ToLower)/app-@(Build.Configuration:ToLower).apk" /> | |||
| <Set Outputs.Bundle="app/build/outputs/bundle/@(Build.Configuration:ToLower)/app-@(Build.Configuration:ToLower).aab" /> | |||
|
|
|||
| <Set ProGuard.PrependRulesFile="@(Project.Android.Optimize.PrependRulesFile:ToLower)" /> | |||
There was a problem hiding this comment.
Naming: I think Proguard should be written with lower-case g (several instances). (In Gradle we write proguardSomething and not proGuardSomething.)
| // the Android Gradle plugin. To learn more, go to the section about | ||
| // R8 configuration files. | ||
| proguardFiles getDefaultProguardFile( | ||
| #if @(Project.Android.Optimize.DefaultAndroidProGuard:IsSet) |
There was a problem hiding this comment.
Naming: I don't think we should repeat Android in this property name. I suggest Project.Android.Optimize.DefaultProguard:IsSet.
| @@ -52,9 +52,20 @@ public override void DeleteOutdated(Disk disk, IEnvironment env) | |||
| var lines = new List<string> {"## This file was generated by Uno compiler."}; | |||
| var src = env.GetOutputPath("Java.SourceDirectory"); | |||
|
|
|||
| // Prepend user-defined proguard rules. | |||
| var proGuardPrependFile = env.GetString("ProGuard.PrependRulesFile"); | |||
There was a problem hiding this comment.
Naming: proguardPrependFile, Proguard.PrependRulesFile?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default android proguard rules(proguard-android.txt) are applied when not specified
Can add custom proguard rules before or after the main generated class rules:
Create "proguard-rules-prepend.pro" in root of Project folder:
e.g.
MyApp/MainView.ux
MyApp/proguard-rules-prepend.pro
...
proguard-rules-prepend.pro