Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Why does image/render.html resize the image to 500x500? #237

Open
gavinwahl opened this issue Jul 28, 2014 · 4 comments
Open

Why does image/render.html resize the image to 500x500? #237

gavinwahl opened this issue Jul 28, 2014 · 4 comments

Comments

@gavinwahl
Copy link
Member

<img src="{{ im.url }}" alt="{{ self.image.label }}">

@rockymeza
Copy link
Contributor

It was an arbitrary decision that I made. Without it, users will upload
giant images that break their site. It was more of a temporary measure
before we figured something out. At that point I had figured that most
users were going to provide their own render templates. I guess we weren't
so clear on how people would use the render templates.

I still think we need to thumbnail it by default, because otherwise it will
break a bunch of sites, but we could make the dimensions more dynamic. We
could have a dimensions property on the Image widget that subclasses
could override or perhaps have it read a context variable. But these are
just my thoughts. Maybe we can get rid of it.

Rocky Meza, Programmer
fusionbox_▝_
o: 303.952.7490

www.fusionbox.com
http://www.fusionbox.com/?utm_source=fb%2Bemail&utm_medium=email&utm_campaign=email%2Btracking

This information is confidential and intended solely for the use
of the individual or entity to whom it is addressed. If you have
received this email in error please notify the sender.

On Mon, Jul 28, 2014 at 11:06 AM, Gavin Wahl notifications@github.com
wrote:

<img src="{{ im.url }}" alt="{{ self.image.label }}">


Reply to this email directly or view it on GitHub
#237.

@zmetcalf
Copy link
Contributor

One thing I liked about it was that it gave an example of using filer and sorl thumbnail together; otherwise, it did mess up a project I was working on so I had to replace the template.

@plee
Copy link

plee commented Mar 11, 2015

Can we just remove the resizing completely, and expect it to be done by CSS? It's kind-of backwards incompatible, could it be a part of 0.4.0? 🐱

@rockymeza
Copy link
Contributor

This could result in very large image sizes on the client-side.

It would be nice to have the image sizes configurable from the widget.

Rocky Meza, Programmer
fusionbox_▝_
o: 303.952.7490

www.fusionbox.com
http://www.fusionbox.com/?utm_source=fb%2Bemail&utm_medium=email&utm_campaign=email%2Btracking

This information is confidential and intended solely for the use
of the individual or entity to whom it is addressed. If you have
received this email in error please notify the sender.

On Tue, Mar 10, 2015 at 9:37 PM, plee notifications@github.com wrote:

Can we just remove the resizing completely, and expect it to be done by
CSS? It's kind-of backwards incompatible, could it be a part of 0.4.0? [image:
🐱]


Reply to this email directly or view it on GitHub
#237 (comment)
.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants